This repository has been archived by the owner on May 3, 2024. It is now read-only.
Fix backwards error message for unsupported join spec version #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrlna
approved these changes
Mar 18, 2024
SimonSapin
force-pushed
the
backwards-message
branch
from
0adaf5e to
49649cb
Compare
> The supergraph schema failed to produce a valid API schema: > Invalid supergraph: uses unsupported join spec version 0.1, 0.2, 0.3 > (supported versions: 0.4)
SimonSapin
force-pushed
the
backwards-message
branch
from
49649cb to
8d42b4f
Compare
Merged
goto-bus-stop
added a commit
that referenced
this pull request
Apr 9, 2024
To release `join/v0.4` for API schema in Router, and a bunch of stuff for QP in Router. ## Features - Query plan changes for initial router integration, by [SimonSapin] in [pull/240] - Mark join/v0.4 spec as supported for non-query planning purpose, by [SimonSapin] in [pull/233], [pull/237] - Continued work on core query planning implementation, by [duckki], [SimonSapin], [TylerBloom] ## Maintenance - Update `apollo-compiler`, by [goto-bus-stop] in [pull/253] [duckki]: https://github.com/duckki [goto-bus-stop]: https://github.com/goto-bus-stop [SimonSapin]: https://github.com/SimonSapin [TylerBloom]: https://github.com/TylerBloom [pull/233]: #233 [pull/237]: #237 [pull/240]: #240 [pull/253]: #253
SimonSapin
added a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
…graphql/federation-next#233) Example previous message: > The supergraph schema failed to produce a valid API schema: Invalid supergraph: uses unsupported join spec version 0.1, 0.2, 0.3 (supported versions: 0.4)
SimonSapin
pushed a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
To release `join/v0.4` for API schema in Router, and a bunch of stuff for QP in Router. ## Features - Query plan changes for initial router integration, by [SimonSapin] in [pull/240] - Mark join/v0.4 spec as supported for non-query planning purpose, by [SimonSapin] in [pull/233], [pull/237] - Continued work on core query planning implementation, by [duckki], [SimonSapin], [TylerBloom] ## Maintenance - Update `apollo-compiler`, by [goto-bus-stop] in [pull/253] [duckki]: https://github.com/duckki [goto-bus-stop]: https://github.com/goto-bus-stop [SimonSapin]: https://github.com/SimonSapin [TylerBloom]: https://github.com/TylerBloom [pull/233]: apollographql/federation-next#233 [pull/237]: apollographql/federation-next#237 [pull/240]: apollographql/federation-next#240 [pull/253]: apollographql/federation-next#253
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example previous message:
Also add https://specs.apollo.dev/join/v0.4 to the list of supported version. Are more changes needed to properly support it? This version seems to exist in apollographql/federation#2907, but it’s not listed on https://specs.apollo.dev/ and https://specs.apollo.dev/join/v0.4 itself is a 404 error as of this writing.