This repository has been archived by the owner on May 3, 2024. It is now read-only.
Mark join v0.4 as supported for non-query planning purpose #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unblocks initial integration in the Router. Also fix the minimum supported version of v0.3, aligning with: https://github.com/apollographql/federation/blob/%40apollo/federation-internals%402.7.2/internals-js/src/specs/joinSpec.ts#L264-L268
goto-bus-stop
approved these changes
Mar 26, 2024
Merged
goto-bus-stop
added a commit
that referenced
this pull request
Apr 9, 2024
To release `join/v0.4` for API schema in Router, and a bunch of stuff for QP in Router. ## Features - Query plan changes for initial router integration, by [SimonSapin] in [pull/240] - Mark join/v0.4 spec as supported for non-query planning purpose, by [SimonSapin] in [pull/233], [pull/237] - Continued work on core query planning implementation, by [duckki], [SimonSapin], [TylerBloom] ## Maintenance - Update `apollo-compiler`, by [goto-bus-stop] in [pull/253] [duckki]: https://github.com/duckki [goto-bus-stop]: https://github.com/goto-bus-stop [SimonSapin]: https://github.com/SimonSapin [TylerBloom]: https://github.com/TylerBloom [pull/233]: #233 [pull/237]: #237 [pull/240]: #240 [pull/253]: #253
SimonSapin
added a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
…phql/federation-next#237) This unblocks initial integration in the Router. Also fix the minimum supported version of v0.3, aligning with: https://github.com/apollographql/federation/blob/%40apollo/federation-internals%402.7.2/internals-js/src/specs/joinSpec.ts#L264-L268
SimonSapin
pushed a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
To release `join/v0.4` for API schema in Router, and a bunch of stuff for QP in Router. ## Features - Query plan changes for initial router integration, by [SimonSapin] in [pull/240] - Mark join/v0.4 spec as supported for non-query planning purpose, by [SimonSapin] in [pull/233], [pull/237] - Continued work on core query planning implementation, by [duckki], [SimonSapin], [TylerBloom] ## Maintenance - Update `apollo-compiler`, by [goto-bus-stop] in [pull/253] [duckki]: https://github.com/duckki [goto-bus-stop]: https://github.com/goto-bus-stop [SimonSapin]: https://github.com/SimonSapin [TylerBloom]: https://github.com/TylerBloom [pull/233]: apollographql/federation-next#233 [pull/237]: apollographql/federation-next#237 [pull/240]: apollographql/federation-next#240 [pull/253]: apollographql/federation-next#253
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks initial integration in the Router.
Also fix the minimum supported version of v0.3, aligning with: https://github.com/apollographql/federation/blob/%40apollo/federation-internals%402.7.2/internals-js/src/specs/joinSpec.ts#L264-L268