Skip to content

Commit

Permalink
Clean up configuration cruft (editor specific, and unused files) (#87)
Browse files Browse the repository at this point in the history
I looked into the various configuration files we currently have checked in, after reading the issue (#86) that was opened on whether or we should have any editor specific files in the repository.

I noticed we check in some files that are not used by anyone, a file that is likely only used by me (and only rarely tbh), and some that we can move to to a designated folder, to reduce some of the clutter without affecting editor functionality.

This PR brings the repo to a state where the only editor specific files are contained in `.idea`. As we discuss the issue mentioned above, we might end up removing this folder all together, but I'd like us to make that decision against this PRs version of the repository (cleaner, less cluttered, reflects one of the suggestions in the issue)

Commits:
* _Move_ all IntelliJ config files to `.idea`
* _Delete_ `cli/.graphqlconfig` -- this doesn't need to be checked in to make anyone more productive in a significant or commonly used way (i.e. this is only for IJ users with a specific plugin and can easily be created locally. I've added it to .gitignore).
* _Delete_ config files that we don't use (`.travis.yml`, `bulk.yaml`, `vagga.yaml`) that were copied over when we forked `graphql-parser`.
* _Rename_ the `github.gql` file to use the more common, seemingly agreed upon, file extension (`.graphql`, see graphql/graphql-spec#203 (comment)).
  • Loading branch information
Ran Magen authored Jun 30, 2020
1 parent 14c8db3 commit 5f30e27
Show file tree
Hide file tree
Showing 16 changed files with 49 additions and 164 deletions.
10 changes: 5 additions & 5 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cdn/cdn.iml → .idea/modules/cdn.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions .idea/modules/cli.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions .idea/modules/graphql-parser.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions .idea/modules/query-planner.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cli/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.schema
.graphqlconfig
16 changes: 0 additions & 16 deletions cli/.graphqlconfig

This file was deleted.

14 changes: 0 additions & 14 deletions cli/cli.iml

This file was deleted.

5 changes: 0 additions & 5 deletions graphql-parser/.editorconfig

This file was deleted.

34 changes: 0 additions & 34 deletions graphql-parser/.travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion graphql-parser/benches/graphql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ fn bench_kitchen_sink(b: &mut test::Bencher) {

#[bench]
fn bench_github(b: &mut test::Bencher) {
let src = include_str!("../../samples/github.gql");
let src = include_str!("../../samples/github.graphql");
b.iter(|| parse_schema(src));
}
8 changes: 0 additions & 8 deletions graphql-parser/bulk.yaml

This file was deleted.

12 changes: 0 additions & 12 deletions graphql-parser/graphql-parser.iml

This file was deleted.

53 changes: 0 additions & 53 deletions graphql-parser/vagga.yaml

This file was deleted.

14 changes: 0 additions & 14 deletions query-planner/query-planner.iml

This file was deleted.

File renamed without changes.

0 comments on commit 5f30e27

Please sign in to comment.