Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up configuration cruft (editor specific, and unused files) #87

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

Enrico2
Copy link
Contributor

@Enrico2 Enrico2 commented Jun 29, 2020

I looked into the various configuration files we currently have checked in, after reading the issue (#86) that was opened on whether or we should have any editor specific files in the repository.

I noticed we check in some files that are not used by anyone, a file that is likely only used by me (and only rarely tbh), and some that we can move to to a designated folder, to reduce some of the clutter without affecting editor functionality.

This PR brings the repo to a state where the only editor specific files are contained in .idea. As we discuss the issue mentioned above, we might end up removing this folder all together, but I'd like us to make that decision against this PRs version of the repository (cleaner, less cluttered, reflects one of the suggestions in the issue)

Commits:

  • Move all IntelliJ config files to .idea
  • Delete cli/.graphqlconfig -- this doesn't need to be checked in to make anyone more productive in a significant or commonly used way (i.e. this is only for IJ users with a specific plugin and can easily be created locally. I've added it to .gitignore).
  • Delete config files that we don't use (.travis.yml, bulk.yaml, vagga.yaml) that were copied over when we forked graphql-parser.
  • Rename the github.gql file to use the more common, seemingly agreed upon, file extension (.graphql, see Recommend an extension to use graphql/graphql-spec#203 (comment)).

Ran Magen added 4 commits June 29, 2020 11:36
…o make anyone more productive in a significant or commonly used way (i.e. this is only for IJ users with a specific plugin and can easily be created locally. I've added it to .gitignore).
…`vagga.yaml`) that were copied over when we forked `graphql-parser`.
@Enrico2 Enrico2 requested a review from a team June 29, 2020 18:43
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm still not convinced we should have these files in this repo, but this is certainly a big improvement! thanks for doing this!

@Enrico2 Enrico2 changed the title Clean up some configuration cruft (editor specific, and unused files) Clean up configuration cruft (editor specific, and unused files) Jun 30, 2020
@Enrico2 Enrico2 merged commit 5f30e27 into main Jun 30, 2020
@Enrico2 Enrico2 deleted the ran/editor_config_organization branch June 30, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants