Introduce @authenticated directive in composition
#2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70b695d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
force-pushed
the
trevor/authenticated
branch
2 times, most recently
from
250504d
to
1dccf3e
Compare
pcmanus
reviewed
Jun 29, 2023
pcmanus
reviewed
Jun 29, 2023
trevor-scheer
force-pushed
the
trevor/authenticated
branch
from
430f425
to
1b1201b
Compare
pcmanus
approved these changes
Jun 30, 2023
trevor-scheer
force-pushed
the
trevor/authenticated
branch
2 times, most recently
from
500769d
to
73b61ab
Compare
3 tasks
clenfest
reviewed
Jul 10, 2023
trevor-scheer
force-pushed
the
trevor/authenticated
branch
from
48bd9c5
to
b12d720
Compare
trevor-scheer
force-pushed
the
trevor/authenticated
branch
from
b12d720
to
b3c7dfb
Compare
pull bot
pushed a commit
to NOUIY/federation
that referenced
this pull request
Nov 28, 2023
Introduce the new `@policy` scope for composition > Note that this directive will only be _fully_ supported by the Apollo Router as a GraphOS Enterprise feature at runtime. Also note that _composition_ of valid `@policy` directive applications will succeed, but the resulting supergraph will not be _executable_ by the Gateway or an Apollo Router which doesn't have the GraphOS Enterprise entitlement. Users may now compose `@policy` applications from their subgraphs into a supergraph. The directive is defined as follows: ```graphql scalar federation__Policy directive @Policy(policies: [[federation__Policy!]!]!) on | FIELD_DEFINITION | OBJECT | INTERFACE | SCALAR | ENUM ``` The `Policy` scalar is effectively a `String`, similar to the `FieldSet` type. In order to compose your `@policy` usages, you must update your subgraph's federation spec version to v2.6 and add the `@policy` import to your existing imports like so: ```graphql @link(url: "https://specs.apollo.dev/federation/v2.6", import: [..., "@Policy"]) ``` For additional context, this PR effectively follows the pattern implemented by apollographql#2644 --------- Co-authored-by: Dariusz Kuc <9501705+dariuszkuc@users.noreply.github.com> Co-authored-by: Geoffroy Couprie <apollo@geoffroycouprie.com> Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
@authenticateddirective for compositionWith this change, users can now compose
@authenticatedapplications from their subgraphs into a supergraph. This addition will support a future version of Apollo Router that enables authenticated access to specific types and fields via directive applications.Since the implementation of
@authenticatedis strictly a composition and execution concern, there's no change to the query planner with this work. The execution work is well under way in Apollo Router (and won't be built at all for Gateway). So as far as this repo is concerned, only composition is concerned with@authenticated.TODO:
@requiresan@authenticatedfield (or open follow up issue for this improvement) Opened@authenticatedand@requiresScopescomposition hints #2670