Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrade to graphql@^0.13.0 #152

Closed
wants to merge 1 commit into from
Closed

Conversation

gr2m
Copy link

@gr2m gr2m commented Feb 7, 2018

there are some failed tests and I am not familiar enough to know if adjusting the tests is the right thing to do or if there is more to be done.

My problem is that I cannot upgrade to the latest graphql because of the peer-dependency in graphql-tag, e.g. see octokit/graphql-schema#26

Please let me know if I shall adjust the tests to make them pass

@apollo-cla
Copy link

@gr2m: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jnwng
Copy link
Contributor

jnwng commented Feb 19, 2018

@gr2m this was a little involved so i added compatibility checks and support for graphql@0.13 in #156. thanks for flagging!

@jnwng jnwng closed this Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants