Adding compatibility check for all supported versions of graphql
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnwng
added a commit
to jnwng/graphql-tag
that referenced
this pull request
Feb 19, 2018
…pollographql#156) * Adding compatibility testing for all `graphql` versions * Running `tav` only in CI and latest otherwise * Bumping to capture more versions of `graphql` * Only check compatibility * Try running `yarn test` instead * Run `tav` _after_ testing latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As new versions of
graphqlget released, its hard to figure out whether or not we're honoring ourpeerDependenciesand actually supporting all versions ofgraphql. test-all-versions allows us to configure our compatibility matrix and run them on every PR to ensure that we know when we're making backwards-incompatible changes.The test files here are split because while the functionality of
graphql-tagdoes not differ between versions, the output of one of the packages we depend on does differ. I'm capturing that difference by splitting the tests and confirming that, yes, we do support both versions. In the future, if a PR were to break one or both of the tests, we could then determine that we need to put through a major version change and also change our compatibility matrix. I wish there was a better way to capture the difference in output besides duplicating the tests.