deferred responses should be compressed

[Geal]

reported by @BoD

with the latest version of the supergraph demo with defer, I’ve added an artificial 4s delay in the Inventory subgraph responses. Then making a query like this:

query Product {
  product(id: "apollo-federation") {
    # Comes from Products subgraph (fast)
    dimensions {
      size
    }

    # Comes from Inventory subgraph (slow)
    ... on Product @defer {
      delivery {
        estimatedDelivery
        fastestDelivery
      }
    }
  }
} 

I was expecting to receive the initial payload immediately and the 2nd one after 4s, but I’m receiving everything at once after 4s.

[BoD]

Here's how I added the delay.

And the curl:

curl 'http://localhost:4000/'   -H 'content-type: application/json'   --data-raw $'{"query":"query Product($productId: ID!) {product(id: $productId) {dimensions {size} ... on Product @defer {delivery { estimatedDelivery fastestDelivery } } } }","variables":{"productId":"apollo-federation"},"operationName":"Product"}' --compressed

[Geal]

thanks, I can reproduce it

[Geal]

ok, the issue is with response compression. If it is not compressed then the chunks come at the right time

[SimonSapin]

We have a work-around for 1.0 but we’d like to switch to a proper solution which is being designed in Nullus157/async-compression#154. Reopening to track that.

[abernix]

I've renamed this issue to reflect the state of the work-around, but we should use the original reproduction above to verify any eventual fix.

[SimonSapin]

I believe 67aae13 provides automated test coverage for this, but if we have another reproduction it’d be good to check as well.

[Geal]

follow up work is in Nullus157/async-compression#178

[Geal]

I'll do that as a custom layer in the router instead