Remove patched async-compression, disable compression for multipart responses instead #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
tiny nit: I think we're trying to use http::header::CONTENT_TYPE (cc @bnjjj)
the rest LGTM
|
Do we care about micro-optimizing code only used in tests? |
|
I personally don’t ^^’ |
bnjjj
approved these changes
Sep 12, 2022
SimonSapin
force-pushed
the
simon/async-compression
branch
from
18cc4fa
to
fba1c4d
Compare
SimonSapin
force-pushed
the
simon/async-compression
branch
from
fba1c4d
to
7c9643f
Compare
…esponses instead This is a different work-around for #1572. The previous work-around required a `[patch.crates-io]` section in the root `Cargo.toml`. When the Router is used as a dependency, that root manifest is not ours so downstream users would need to apply the same patch to get the work-around. This came up in the context of publish the Router to crates.io #491 but applies the same when the `apollo-router` crate is used as a git dependency.
SimonSapin
force-pushed
the
simon/async-compression
branch
from
7c9643f
to
f5295f8
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different work-around for #1572.
The previous work-around required a
[patch.crates-io]section in the rootCargo.toml. When the Router is used as a dependency, that root manifest is not ours so downstream users would need to apply the same patch to get the work-around.This came up in the context of publish the Router to crates.io #491 but applies the same when the
apollo-routercrate is used as a git dependency.