docker: Define ENTRYPOINT as absolute path #1684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
I'm running up
apollographql/router
by Docker Compose for my local development. And, I'm changing the working directory for therouter
image like below in order to mount my application repository:Since the current Dockerfile specifies a relative path (
./router
) forENTRYPOINT
, changing the working directory causes an errorThough I know specifying
entrypoint: /dist/router
to mydocker-compose.yml
fixes the problem, it requires users of therouter
image to recognize the working directory of the image (/dist
) to do so, and I think it's not user friendly.So, I created this PR that changes
ENTRYPOINT
from a relative./router
to an absolute/dist/router
.