Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Define ENTRYPOINT as absolute path #1684

Merged
merged 2 commits into from
Sep 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/p
## 🚀 Features
## 🐛 Fixes

### Docker images: Use absolute path for `ENTRYPOINT` ([PR #1684](https://github.com/apollographql/router/pull/1684))

This restores the absolute path in `ENTRYPOINT` in our `Dockerfile`s (and published images) to allow users to change their working directory without consequence (and without needing to change it back to `/dist` or override the `entrypoint`).

By [@110y](https://github.com/110y) in https://github.com/apollographql/router/pull/1684


### Update our helm documentation to illustrate how to use our registry ([#1643](https://github.com/apollographql/router/issues/1643))

The helm chart never used to have a registry, so our docs were really just placeholders. I've updated them to reflect the fact that we now store the chart in our OCI registry.
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.router
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ COPY --from=build --chown=root:root /dist .
ENV APOLLO_ROUTER_CONFIG_PATH="/dist/config/router.yaml"

# Default executable is the router
ENTRYPOINT ["./router"]
ENTRYPOINT ["/dist/router"]
2 changes: 1 addition & 1 deletion dockerfiles/diy/dockerfiles/Dockerfile.release
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ COPY --from=build --chown=root:root /dist .
ENV APOLLO_ROUTER_CONFIG_PATH="/dist/config/router.yaml"

# Default executable is the router
ENTRYPOINT ["./router"]
ENTRYPOINT ["/dist/router"]
2 changes: 1 addition & 1 deletion dockerfiles/diy/dockerfiles/Dockerfile.repo
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ WORKDIR /dist
ENV APOLLO_ROUTER_CONFIG_PATH="/dist/config/router.yaml"

# Default executable is the router
ENTRYPOINT ["./router"]
ENTRYPOINT ["/dist/router"]