Add a private part to the Context structure #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hashmap-like indexed by the type of the value inserted
This comment has been minimized.
This comment has been minimized.
bnjjj
reviewed
Mar 17, 2023
apollo-router/src/context/mod.rs
Outdated
| @@ -36,6 +40,9 @@ pub struct Context { | |||
| // Allows adding custom entries to the context. | |||
| entries: Entries, | |||
|
|
|||
| #[serde(skip, default)] | |||
| pub(crate) private_entries: Arc<std::sync::Mutex<Extensions>>, | |||
There was a problem hiding this comment.
Don't you think a RwLock could be interesting in that case ? I think we're mostly writing outside of subgraph_service
There was a problem hiding this comment.
that could be, but there would not be much performance benefit, there will very rarely be concurrent accesses
bnjjj
approved these changes
Apr 6, 2023
o0Ignition0o
approved these changes
Apr 6, 2023
garypen
reviewed
Apr 17, 2023
|
yup, it's just that before, some internal details, that we did not meant as public API, were sent to the coprocessor. This will be stricter now |
Geal
added a commit
that referenced
this pull request
Apr 25, 2023
There's a cost in using the `Context` structure throughout a request's lifecycle, due to the JSON serialization and deserialization, so it should be reserved from inter plugin communication between rhai, coprocessor and Rust. But for internal router usage, we can have a more efficient structure that avoids serialization costs, and does not expose data that should not be modified by plugins. That structure is based on a map indexed by type id, which means that if some part of the code can see that type, then it can access it in the map. This means that some context data that was accessible from rhai and all plugins, is now inaccessible
Geal
added a commit
that referenced
this pull request
May 15, 2023
Batch of performance improvements: * linux: replace default allocator with jemalloc (#2882) * Add a private part to the Context structure (#2802) * lighter path manipulation in response formatting (#2854) * prevent span attributes from being formatted to write logs (#2890) * Parse Accept headers once instead of three times (#2847) * use a parking-lot mutex in Context (#2885) * Filter spans before sending them to the opentelemetry layer (#2894)
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2800
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test