linux: replace default allocator with jemalloc #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Geal
reviewed
Mar 31, 2023
garypen
force-pushed
the
garypen/jemalloc
branch
from
6e71900
to
ea2182b
Compare
bnjjj
approved these changes
Apr 6, 2023
Geal
approved these changes
Apr 14, 2023
o0Ignition0o
approved these changes
Apr 17, 2023
and not "unix-like" OSs. i.e.: Linux, BSD, OSX...
garypen
changed the title
SimonSapin
approved these changes
Apr 17, 2023
|
perf test please |
Closed
Geal
pushed a commit
that referenced
this pull request
Apr 25, 2023
Router execution results in a heavily fragmented heap, that is hard to manage for the default allocator. jemallocator handles it better, which results in performance improvements, in latency and memory usage
Geal
added a commit
that referenced
this pull request
May 15, 2023
Batch of performance improvements: * linux: replace default allocator with jemalloc (#2882) * Add a private part to the Context structure (#2802) * lighter path manipulation in response formatting (#2854) * prevent span attributes from being formatted to write logs (#2890) * Parse Accept headers once instead of three times (#2847) * use a parking-lot mutex in Context (#2885) * Filter spans before sending them to the opentelemetry layer (#2894)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment with jemalloc.
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
- Tests added and passing[^3]- [ ] Unit Tests- [ ] Integration Tests- [ ] Manual TestsExceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test