Skip to content

Commit

Permalink
feat: removes -V from subcommands + strict utf-8 (#487)
Browse files Browse the repository at this point in the history
  • Loading branch information
EverlastingBugstopper committed May 3, 2021
1 parent e7026ff commit 72fcc33
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 6 deletions.
24 changes: 20 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,32 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

<!-- # [x.x.x] (unreleased) - 2021-mm-dd
> Important: X breaking changes below, indicated by **❗ BREAKING ❗**
## 🚀 Features
## ❗ BREAKING ❗
## 🚀 Features
## 🐛 Fixes
## 🛠 Maintenance
## 📚 Documentation -->

# [x.x.x] (unreleased) - 2021-mm-dd
> Important: X breaking changes below, indicated by **❗ BREAKING ❗**
## 🚀 Features
# [0.0.11] (upcoming) - 2021-05-11
> Important: 1 breaking change below, indicated by **❗ BREAKING ❗**
## ❗ BREAKING ❗

- **Removes -V/--version flag from subcommands - [EverlastingBugstopper], [pull/487]**

Rover's subcommands will always be the same version as Rover, so we no longer accept `-V` or `--version`
on Rover's subcommands.

[EverlastingBugstopper]: https://github.com/EverlastingBugstopper
[pull/487]: https://github.com/apollographql/rover/pull/487

- **Disallow all non-UTF-8 argument values - [EverlastingBugstopper], [pull/487]**

Rover will no longer accept any argument values that cannot be properly interpreted as UTF-8.

[EverlastingBugstopper]: https://github.com/EverlastingBugstopper
[pull/487]: https://github.com/apollographql/rover/pull/487

## 🚀 Features
## 🐛 Fixes
## 🛠 Maintenance

Expand Down
11 changes: 9 additions & 2 deletions src/cli.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use serde::Serialize;
use structopt::StructOpt;
use structopt::{clap::AppSettings, StructOpt};

use crate::command::{self, RoverStdout};
use crate::utils::{
Expand All @@ -17,7 +17,14 @@ use timber::{Level, LEVELS};
use camino::Utf8PathBuf;

#[derive(Debug, Serialize, StructOpt)]
#[structopt(name = "Rover", global_settings = &[structopt::clap::AppSettings::ColoredHelp], about = "
#[structopt(
name = "Rover",
global_settings = &[
AppSettings::ColoredHelp,
AppSettings::StrictUtf8,
AppSettings::VersionlessSubcommands,
],
about = "
Rover - Your Graph Companion
Read the getting started guide by running:
Expand Down

0 comments on commit 72fcc33

Please sign in to comment.