feat: removes -V from subcommands + strict utf-8 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
feature 🎉
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
lrlna
approved these changes
May 3, 2021
There was a problem hiding this comment.
Yep, let's get this in before May 11!
@EverlastingBugstopper do you want to start a UPCOMING entry in the changelog as part of this PR?
JakeDawkins
approved these changes
May 3, 2021
EverlastingBugstopper
force-pushed
the
avery/versionless-subcommands
branch
from
0077e8b
to
65566a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added two new global app settings for rover, the first will reject any non-utf8 arguments, and the second removes the
--version/-Vflag from subcommands since we do not version our subcommands differently from rover itself. technically this is a breaking change, but one that should be very very low impact.