Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print link to getting started after installation #433

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Apr 9, 2021

fixes #141 by printing the output of rover --help as long as the user does not need to reload their shell to get rover in their PATH.

if we think it's too much output right away, i'm happy to come up with an alternative solution that's a bit less verbose!

@EverlastingBugstopper EverlastingBugstopper added the feature 🎉 new commands, flags, functionality, and improved error messages label Apr 9, 2021
@EverlastingBugstopper EverlastingBugstopper added this to the April 13 milestone Apr 9, 2021
@JakeDawkins
Copy link
Contributor

Nice! I feel like the --help text seems a little verbose as a post-install message. I'm not necessarily opposed, but I feel like it could be annoying to have a wall of text on install rather than a help message. Thoughts on that?

@EverlastingBugstopper
Copy link
Contributor Author

yeah i also had that reaction - maybe we print the url to the docs if rover isn't in their PATH yet and if it is already there we can print just the line: You can read the getting started guide by running rover docs open start. that seems more manageable to me.

@JakeDawkins
Copy link
Contributor

Agreed, that seems a bit less "in your face"

@EverlastingBugstopper EverlastingBugstopper changed the title feat: print rover --help in postinstall if rover is in PATH feat: print link to getting started after installation Apr 12, 2021
@lrlna lrlna merged commit ffaae5b into main Apr 13, 2021
@lrlna lrlna deleted the avery/post-install branch April 13, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Post-install message pointing to docs & getting started
3 participants