APPSRE-7775 bump nodejs to next lts #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you provide documentation/details about the "funny stuff"? A link may suffice. |
hemslo
reviewed
Sep 18, 2023
There was a problem hiding this comment.
--openssl-legacy-provider details can be found facebook/create-react-app#11562. Can cleanup after we upgrade dependencies.
fishi0x01
force-pushed
the
APPSRE-7775_nodejs-bump
branch
from
1316f9a to
4150bf2
Compare
|
/retest |
1 similar comment
|
/retest |
|
|
Merged
|
This can be closed in favor of #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs16 reached EOL. Lets bump to next LTS 18.
Note: starting with node17 there is funny stuff with openssl. For now, setting
--openssl-legacy-providerfor compatibility. However, long-term we should consider upgradingreact-scripts.