Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSRE-7775 bump nodejs to next lts #194

Closed
wants to merge 2 commits into from
Closed

APPSRE-7775 bump nodejs to next lts #194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637e572
APPSRE-7775 bump nodejs to next lts
fishi0x01 Sep 15, 2023
4150bf2
APPSRE-7775 add missing flag
fishi0x01 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodejs 18.16.1
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/nodejs-16
FROM registry.access.redhat.com/ubi8/nodejs-18

USER root

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.tester
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/nodejs-16
FROM registry.access.redhat.com/ubi8/nodejs-18

USER root

Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ build-test:

test: build-test
@docker run --rm $(IMAGE_TEST)

dev-docker-run: build
docker run --rm -p 8080:8080 -e AUTHORIZATION=blub -e API_AUTH=blub -e API_URI=https://app-interface.devshift.net -e GRAPHQL_URI=https://app-interface.devshift.net -v $(shell pwd)/public/env:/opt/visual-qontract/build/env $(IMAGE_NAME):latest
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,7 @@ It is written in [React](https://reactjs.org/) and uses [PatternFly 3](https://w

```sh
$ cp public/env/env.js.example public/env/env.js
$ sed -i.bk '/GRAPHQL_URI/d' public/env/env.js
$ docker run --rm -p 8080:8080 \
-e AUTHORIZATION="Basic <TOKEN>" -e GRAPHQL_URI="<URL>" \
-v $PWD/public/env:/opt/visual-qontract/build/env:z \
quay.io/app-sre/visual-qontract:latest
$ make dev-docker-run
```

The visual-qontract UI will be reachable on http://localhost:8080
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"copy-img": "ncp node_modules/patternfly/dist/img src/img",
"build-css": "sass --style compressed $npm_package_sassIncludes_src $npm_package_sassIncludes_patternfly $npm_package_sassIncludes_patternflyReact $npm_package_sassIncludes_bootstrap $npm_package_sassIncludes_fontAwesome src/",
"watch-css": "yarn build-css && sass --watch --style compressed $npm_package_sassIncludes_src $npm_package_sassIncludes_patternfly $npm_package_sassIncludes_patternflyReact $npm_package_sassIncludes_bootstrap $npm_package_sassIncludes_fontAwesome src/",
"build-js": "react-scripts build",
"build-js": "react-scripts --openssl-legacy-provider build",
hemslo marked this conversation as resolved.
Show resolved Hide resolved
"start:dev": "npm-run-all -p watch-css start:local build-fragment",
"start:local": "react-scripts start",
"build": "yarn copy-fonts && yarn copy-img && yarn build-css && yarn build-js && yarn postbuild",
Expand Down