This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
schema/labels: consistently order LabelsFromMap #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the slice of labels produced by LabelsFromMap could have any arbitrary ordering. See appc/docker2aci#245 for one of the issues this causes in practice. I also renamed the type 'labels' to 'labelsSlice' since, as it was, it was being constantly shadowed. This is not accompanied with any spec change since labels in the appc spec are already a slice, and thus already have a consistent ordering. It's unfortunate that a round trip of ToMap/FromMap won't be consistent, but I don't think any callers actually do that currently.
cgonyeo
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the slice of labels produced by LabelsFromMap
could have any arbitrary ordering.
See appc/docker2aci#245 for one of the issues
this causes in practice.
I also renamed the type 'labels' to 'labelsSlice' since, as it was, it
was being constantly shadowed.
This is not accompanied with any spec change since labels in the appc
spec are already a slice, and thus already have a consistent ordering.
It's unfortunate that a round trip of ToMap/FromMap won't be consistent,
but I don't think any callers actually do that currently.