Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

schema/labels: consistently order LabelsFromMap #689

Merged
merged 1 commit into from
Jul 4, 2017

Commits on Jun 12, 2017

  1. schema/labels: consistently order LabelsFromMap

    Prior to this change, the slice of labels produced by LabelsFromMap
    could have any arbitrary ordering.
    
    See appc/docker2aci#245 for one of the issues
    this causes in practice.
    
    I also renamed the type 'labels' to 'labelsSlice' since, as it was, it
    was being constantly shadowed.
    
    This is not accompanied with any spec change since labels in the appc
    spec are already a slice, and thus already have a consistent ordering.
    It's unfortunate that a round trip of ToMap/FromMap won't be consistent,
    but I don't think any callers actually do that currently.
    euank committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    de6562a View commit details
    Browse the repository at this point in the history