#38 - Selenium binary host configuration #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional environment variable to use a custom Selendroid binary host.
|
|
jlipps
reviewed
Dec 13, 2016
| @@ -6,7 +6,8 @@ import log from './logger'; | |||
| import crypto from 'crypto'; | |||
|
|
|||
| const SE_VER = "0.17.0"; | |||
| const SE_DOWNLOAD = `http://repo1.maven.org/maven2/io/selendroid/selendroid-standalone/${SE_VER}/selendroid-standalone-${SE_VER}-with-dependencies.jar`; | |||
| const SE_DOWNLOAD_CDNURL = process.env.APPIUM_SELENDROID_CDNURL || "http://repo1.maven.org/maven2/io/selendroid/selendroid-standalone"; | |||
There was a problem hiding this comment.
would be great to include this as an npm install parameter as well as an environment variable, like we do in appium-chromedriver; care to add that? otherwise this looks great.
There was a problem hiding this comment.
Good idea, I update the code ;)
Thanks
Selenium binary host configuration with npm arguments or environment variable. Thanks jlipps for this remark !
jlipps
approved these changes
Dec 13, 2016
Update README.md to add the custom binaries url configuration
|
published in 1.5.0 |
|
Cool, thanks @jlipps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional environment variable to use a custom Selendroid binary host.