Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 - Selenium binary host configuration #39

Merged
merged 3 commits into from
Dec 13, 2016
Merged

#38 - Selenium binary host configuration #39

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b58a345
#38 - Selenium binary host configuration
marcbuils Dec 13, 2016
3448eb3
#38 - Selenium binary host configuration
marcbuils Dec 13, 2016
b65f5a5
#38 - Selenium binary host configuration
marcbuils Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/installer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import log from './logger';
import crypto from 'crypto';

const SE_VER = "0.17.0";
const SE_DOWNLOAD = `http://repo1.maven.org/maven2/io/selendroid/selendroid-standalone/${SE_VER}/selendroid-standalone-${SE_VER}-with-dependencies.jar`;
const SE_DOWNLOAD_CDNURL = process.env.APPIUM_SELENDROID_CDNURL || "http://repo1.maven.org/maven2/io/selendroid/selendroid-standalone";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to include this as an npm install parameter as well as an environment variable, like we do in appium-chromedriver; care to add that? otherwise this looks great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I update the code ;)
Thanks

const SE_DOWNLOAD = `${SE_DOWNLOAD_CDNURL}/${SE_VER}/selendroid-standalone-${SE_VER}-with-dependencies.jar`;
const SE_DOWNLOAD_SHA256 = "7cf7163ac47f1c46eff95b62f78b58c1dabdec534acc6632da3784739f6e9d82";
const SE_DIR = path.resolve(__dirname, "..", "..", "selendroid");
const SE_DOWNLOAD_DIR = path.resolve(SE_DIR, "download");
Expand Down