torch.log(): cast int arguments to float32
#2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
added a commit
to huggingface/exporters
that referenced
this pull request
Oct 16, 2023
Includes a workaround for apple/coremltools#2017
junpeiz
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Thank you for fixing this issue! LGTM.
I kicked off an CI run: https://gitlab.com/coremltools1/coremltools/-/pipelines/1043280060
|
Thanks @junpeiz! Looks like the CI run finished successfully, let me know if you'd like any changes :) |
|
Great! We will merge it after the release is finished. Thank you for your patience! |
|
Oh, of course, no worries at all! |
junpeiz
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.logautomatically casts arguments tofloat32:However, the same operation fails when converting to Core ML.
This patch makes it possible to convert
mistralmodels, such as mistralai/Mistral-7B-Instruct-v0.1.