Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.1 release #2027

Merged
merged 1 commit into from
Nov 1, 2023
Merged

7.1 release #2027

merged 1 commit into from
Nov 1, 2023

Conversation

DawerG
Copy link
Collaborator

@DawerG DawerG commented Oct 24, 2023 •
edited
Loading

@DawerG DawerG force-pushed the 7.1-release branch 3 times, most recently from af6ff9e to af2de58 Compare October 24, 2023 17:40
@DawerG DawerG force-pushed the 7.1-release branch 2 times, most recently from 63d3030 to 0725b42 Compare October 26, 2023 01:27
TobyRoseman
TobyRoseman previously approved these changes Oct 26, 2023
View reviewed changes
junpeiz
junpeiz previously approved these changes Oct 27, 2023
View reviewed changes
@junpeiz junpeiz mentioned this pull request Oct 27, 2023
Merged
@TobyRoseman TobyRoseman mentioned this pull request Oct 27, 2023
Merged
@jakesabathia2 jakesabathia2 mentioned this pull request Oct 27, 2023
Merged
jakesabathia2
jakesabathia2 previously approved these changes Oct 27, 2023
View reviewed changes
tonybove-apple
tonybove-apple previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@tonybove-apple tonybove-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw one docstring with possible formatting problems with indents and suggested corrections.

coremltools/converters/_converters_entry.py Show resolved Hide resolved
@junpeiz junpeiz merged commit dbb0094 into apple:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpeiz junpeiz junpeiz approved these changes

@tonybove-apple tonybove-apple tonybove-apple left review comments

@jakesabathia2 jakesabathia2 jakesabathia2 left review comments

@TobyRoseman TobyRoseman TobyRoseman left review comments

@aseemw aseemw Awaiting requested review from aseemw

@YifanShenSZ YifanShenSZ Awaiting requested review from YifanShenSZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DawerG @TobyRoseman @junpeiz @jakesabathia2 @tonybove-apple