Skip to content

Commit

Permalink
Deprecate `io.servicetalk.client.api.internal.DefaultPartitionedClien…
Browse files Browse the repository at this point in the history
…tGroup` (#2305)

Motivation:

#2131 and #2267 deprecates partitioned http client and classes required
for its impl, but `DefaultPartitionedClientGroup` is still not
deprecated.

Modifications:

- Deprecate
`io.servicetalk.client.api.internal.DefaultPartitionedClientGroup`;

Result:

All (hopefully) classes related to "partitioned" client are deprecated
now.

Signed-off-by: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
  • Loading branch information
idelpivnitskiy authored Aug 4, 2022
1 parent 943d7d5 commit 24ad6cc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@
* @param <U> the type of address before resolution (unresolved address)
* @param <R> the type of address after resolution (resolved address)
* @param <Client> the type of client to connect to the partitions
* @deprecated We are unaware of anyone using "partition" feature and plan to remove it in future releases.
* If you depend on it, consider using {@link ClientGroup} as an alternative or reach out to the maintainers describing
* the use-case.
*/
@Deprecated // FIXME: 0.43 - remove deprecated class
public final class DefaultPartitionedClientGroup<U, R, Client extends ListenableAsyncCloseable>
implements ClientGroup<PartitionAttributes, Client> {

Expand All @@ -69,7 +73,11 @@ public final class DefaultPartitionedClientGroup<U, R, Client extends Listenable
* @param <U> the type of address before resolution (unresolved address)
* @param <R> the type of address after resolution (resolved address)
* @param <Client> the type of client to connect to the partitions
* @deprecated We are unaware of anyone using "partition" feature and plan to remove it in future releases.
* If you depend on it, consider using {@link ClientGroup} as an alternative or reach out to the maintainers
* describing the use-case.
*/
@Deprecated
@FunctionalInterface
public interface PartitionedClientFactory<U, R, Client> {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import static java.util.Objects.requireNonNull;
import static java.util.function.Function.identity;

@Deprecated // FIXME: 0.43 - remove deprecated class
final class DefaultPartitionedHttpClientBuilder<U, R> implements PartitionedHttpClientBuilder<U, R> {
private static final Logger LOGGER = LoggerFactory.getLogger(DefaultPartitionedHttpClientBuilder.class);

Expand Down

0 comments on commit 24ad6cc

Please sign in to comment.