Deprecate internal classes related to partitioning #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: All public classes and interfaces that target partitioning feature were deprecated in apple#2131. Modification: - Deprecate everything inside `io.servicetalk.client.api.internal.partition` package; Result: All internal classes related to partitioning are deprecated too.
bondolo
approved these changes
Jul 12, 2022
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Aug 3, 2022
…tGroup` Motivation: apple#2131 and apple#2267 deprecates partitioned http client and classes required for its impl, but `DefaultPartitionedClientGroup` is still not deprecated. Modifications: - Deprecate `io.servicetalk.client.api.internal.DefaultPartitionedClientGroup`; Result: All (hopefully) classes related to "partitioned" client are deprecated now. Signed-off-by: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
idelpivnitskiy
added a commit
that referenced
this pull request
Aug 4, 2022
…tGroup` (#2305) Motivation: #2131 and #2267 deprecates partitioned http client and classes required for its impl, but `DefaultPartitionedClientGroup` is still not deprecated. Modifications: - Deprecate `io.servicetalk.client.api.internal.DefaultPartitionedClientGroup`; Result: All (hopefully) classes related to "partitioned" client are deprecated now. Signed-off-by: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
All public classes and interfaces that target partitioning feature were
deprecated in #2131.
Modification:
io.servicetalk.client.api.internal.partitionpackage;Result:
All internal classes related to partitioning are deprecated too.