Skip to content

Commit

Permalink
Deprecate internal classes related to partitioning (#2267)
Browse files Browse the repository at this point in the history
Motivation:

All public classes and interfaces that target partitioning feature were
deprecated in #2131.

Modification:

- Deprecate everything inside
`io.servicetalk.client.api.internal.partition` package;

Result:

All internal classes related to partitioning are deprecated too.
  • Loading branch information
idelpivnitskiy authored Jul 12, 2022
1 parent 6e023e0 commit 4d890e8
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package io.servicetalk.client.api.internal.partition;

import io.servicetalk.client.api.ClientGroup;
import io.servicetalk.client.api.partition.DuplicateAttributeException;
import io.servicetalk.client.api.partition.PartitionAttributes;
import io.servicetalk.client.api.partition.PartitionAttributes.Key;
Expand All @@ -35,7 +36,12 @@
* {@link PartitionAttributes}. The goals are to provide fast {@link Object#equals(Object)} and
* {@link Object#hashCode()} which do not require intermediate object allocation and pointer traversal
* (e.g. {@link Iterator}).
*
* @deprecated We are unaware of anyone using "partition" feature and plan to remove it in future releases.
* If you depend on it, consider using {@link ClientGroup} as an alternative or reach out to the maintainers describing
* the use-case.
*/
@Deprecated
public final class DefaultPartitionAttributesBuilder implements PartitionAttributesBuilder {
private static final int PARENT_MASK = ~0x1;
private Object[] keyValueArray;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package io.servicetalk.client.api.internal.partition;

import io.servicetalk.client.api.ClientGroup;
import io.servicetalk.client.api.partition.PartitionAttributes;
import io.servicetalk.client.api.partition.PartitionAttributesBuilder;
import io.servicetalk.client.api.partition.PartitionMap;
Expand Down Expand Up @@ -42,8 +43,13 @@
/**
* A {@link PartitionMap} that creates the full power set using the individual attributes in
* {@link PartitionAttributes}es to create partitions for each {@link #add(PartitionAttributes)}.
*
* @param <T> The partition type.
* @deprecated We are unaware of anyone using "partition" feature and plan to remove it in future releases.
* If you depend on it, consider using {@link ClientGroup} as an alternative or reach out to the maintainers describing
* the use-case.
*/
@Deprecated
public final class PowerSetPartitionMap<T extends AsyncCloseable> implements PartitionMap<T> {
private static final byte CLOSED_GRACEFULLY = 1;
private static final byte HARD_CLOSE = 2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package io.servicetalk.client.api.internal.partition;

import io.servicetalk.client.api.ClientGroup;
import io.servicetalk.client.api.partition.PartitionAttributes;
import io.servicetalk.client.api.partition.PartitionMap;
import io.servicetalk.client.api.partition.PartitionMapFactory;
Expand All @@ -24,7 +25,12 @@

/**
* A {@link PartitionMapFactory} that generates {@link PowerSetPartitionMap} type objects.
*
* @deprecated We are unaware of anyone using "partition" feature and plan to remove it in future releases.
* If you depend on it, consider using {@link ClientGroup} as an alternative or reach out to the maintainers describing
* the use-case.
*/
@Deprecated
public final class PowerSetPartitionMapFactory implements PartitionMapFactory {
/**
* Singleton instance.
Expand Down

0 comments on commit 4d890e8

Please sign in to comment.