Add method to lazily parse a SET from a ASN1Node
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motiviation We want reduce allocations in swift-certificates and need a way to parse without allocating an intermediate `Array`. ### Modifications add `DER.lazySet(of:identifier:rootNode)` which returns its result without allocating. ### Result We can eliminate allocations during parsing
Lukasa
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motiviation
We want reduce allocations in swift-certificates and need a way to parse without allocating an intermediate
Array.Modifications
add
DER.lazySet(of:identifier:rootNode)which returns its result without allocating.Result
We can eliminate allocations during parsing