Do not allocate for RelativeDistinguishedNames with just a single attribute
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
465 allocs
This reverts commit 4af11bb.
Conflicts: IntegrationTests/run-tests.sh IntegrationTests/tests_01_allocation_counters/test_01_resources/shared.swift docker/docker-compose.2204.57.yaml docker/docker-compose.2204.58.yaml docker/docker-compose.2204.59.yaml docker/docker-compose.2204.main.yaml
# Conflicts: # IntegrationTests/run-tests.sh # IntegrationTests/tests_01_allocation_counters/test_01_resources/run-swift-certificates-alloc-counter-tests.sh # IntegrationTests/tests_01_allocation_counters/test_01_resources/shared.swift # Tests/X509Tests/TinyArrayTests.swift # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml # docker/docker-compose.2204.main.yaml
and apply review feedback
# Conflicts: # IntegrationTests/tests_01_allocation_counters/test_01_resources/test_tiny_array_cow_append_contents_of.swift # IntegrationTests/tests_01_allocation_counters/test_01_resources/test_tiny_array_non_allocating_operations.swift # Sources/X509/TinyArray.swift # Sources/X509/_TinyArray.swift # Sources/_CertificateInternals/_TinyArray.swift # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml # docker/docker-compose.2204.main.yaml
# Conflicts: # IntegrationTests/tests_01_allocation_counters/test_01_resources/test_tiny_array_cow_append_contents_of.swift # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml # docker/docker-compose.2204.main.yaml
# Conflicts: # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml # docker/docker-compose.2204.main.yaml
# Conflicts: # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml # docker/docker-compose.2204.main.yaml
Lukasa
reviewed
Jun 29, 2023
| /// - rootNode: The ``ASN1Node`` to parse | ||
| /// - returns: An array of elements representing the elements in the sequence. | ||
| @inlinable | ||
| public static func lazySet<T: DERParseable>(of: T.Type = T.self, identifier: ASN1Identifier, rootNode: ASN1Node) throws -> some Sequence<Result<T, Error>> { |
There was a problem hiding this comment.
It's pretty unfortunate to have to add this, and its supporting code, here: doubly so that we've made it public. Can we push this down into ASN1?
There was a problem hiding this comment.
Yes sure, I just didn't like that particular name and couldn't come up with a better one.
|
@swift-server-bot test this please |
# Conflicts: # docker/docker-compose.2204.57.yaml # docker/docker-compose.2204.58.yaml # docker/docker-compose.2204.59.yaml
|
Allocations are reduce by ~7% for parsing certificates 93b35b8 |
|
|
|
@swift-server-bot test this please |
|
API breakage checker failure is a bug in swift: swiftlang/swift#67113 |
Lukasa
reviewed
Jul 4, 2023
| } | ||
|
|
||
| @inlinable | ||
| init(_ attributes: some Sequence<Result<RelativeDistinguishedName.Attribute, some Error>>) throws { |
There was a problem hiding this comment.
Do we need this to be fully generic? Or can we just accept the actual type?
There was a problem hiding this comment.
Nope, have changed it: d2ca572
Lukasa
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A
RelativeDistinguishedNamehas almost always just a singleAttributebut we currently always allocate an array.Modification
_TinyArrayinstead ofArrayas the internal storage forAttributes inRelativeDistinguishedNameswift-asn1. We might want to think about porting it back toswift-asn1but need to think about the right public API for that which we can start in this PR.RelativeDistinguishedNameinit can't fail and therefore it is now non-throwing initResult
Allocations have improved