Add support for package visibility modifier
#1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
requested changes
Sep 26, 2023
gjcairo
force-pushed
the
package-visibility
branch
2 times, most recently
from
68c6a02 to
e2c79d5
Compare
thomasvl
reviewed
Sep 26, 2023
gjcairo
force-pushed
the
package-visibility
branch
from
e2c79d5 to
d88d9b1
Compare
thomasvl
approved these changes
Sep 28, 2023
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Jan 2, 2024
Follow up to apple#1472, looks like we didn't realize this gate should also be updated.
thomasvl
added a commit
that referenced
this pull request
Jan 3, 2024
Follow up to #1472, looks like we didn't realize this gate should also be updated.
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Jan 3, 2024
Follow up to apple#1472, looks like we didn't realize this gate should also be updated.
thomasvl
added a commit
that referenced
this pull request
Jan 3, 2024
Follow up to #1472, looks like we didn't realize this gate should also be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
packagevisibility modifier, introduced with Swift 5.9.It also adds support for Swift 5.9, by updating the Package.swift's
swift-tools-versiont o 5.9 (required to usepackage) and moving the existing Package.swift to Package@swift-5.8.swift.