Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow implementationOnly with package visibility. #1531

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Jan 2, 2024

Follow up to #1472, looks like we didn't realize this gate should also be updated.

Follow up to apple#1472, looks like we didn't realize this gate should also be updated.
@thomasvl thomasvl requested review from FranzBusch and tbkka January 2, 2024 20:39
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 2, 2024

@gjcairo fyi.

Copy link
Contributor

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Thomas, thanks for the fix!

@thomasvl thomasvl merged commit 71f3b3b into apple:main Jan 3, 2024
9 checks passed
@thomasvl thomasvl deleted the visibility_and_implonly branch January 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants