This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
dict_keys and dict_values types do not work with filter_by #2221 #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, but it would be fantastic to add a unit test for this. Please just add a "this works" test in test/test_sframe.py. Thanks @dhivyaaxim for the great work!! |
hoytak
approved these changes
Oct 22, 2019
|
The error that caused the above CI failures has been fixed elsewhere. Could you merge in master and push again? |
|
@hoytak Thanks! Can you merge this changes to master? |
|
@dhivyaaxim - Thanks for another great bug fix. For future reference: once your changes have been approved and passed Travis CI, feel free to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2221
dict_keys and dict_values types do not work with filter_by