dict_keys and dict_values types do not work with filter_by #2221

src/python/turicreate/data_structures/sarray.py

@@ -375,7 +375,7 @@ def _is_iterable_required_to_listify(cls, obj):
         # In Python 3, str implements '__iter__'.
         return (isinstance(obj, types.GeneratorType) or
                 (sys.version_info.major < 3 and isinstance(obj, six.moves.xrange)) or
-                sys.version_info.major >= 3 and isinstance(obj, (range, filter, map)))
+                sys.version_info.major >= 3 and isinstance(obj, (range, filter, map, collections.abc.KeysView, collections.abc.ValuesView)))
 
 
     def __init__(self, data=[], dtype=None, ignore_cast_failure=False, _proxy=None):

src/python/turicreate/test/test_sframe.py

@@ -3772,6 +3772,20 @@ def test_add_column_noniterable2(self):
 
         _assert_sframe_equal(sf, sf_test)
 
+
+    def test_filter_by_dict(self):
+        # Check for dict in filter_by
+        sf = SFrame({'check':range(10)})
+        d = {1:1}
+
+        sf = sf.filter_by(d.keys(),'check')
+        sf_test = sf.filter_by(list(d.keys()),'check')
+        _assert_sframe_equal(sf, sf_test)
+
+        sf = sf.filter_by(d.values(),'check')
+        sf_test = sf.filter_by(list(d.values()),'check')
+        _assert_sframe_equal(sf, sf_test)
+
 
 if __name__ == "__main__":