Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beego_test and add fiberEngine Test. #86

Merged
merged 5 commits into from
Jun 27, 2021
Merged

Conversation

ralic
Copy link
Contributor

@ralic ralic commented Jan 16, 2021

Revised PR. To add new feature to support fiber engine. (https://github.com/gofiber)

Original PR: #83

_example/beego_test.go Outdated Show resolved Hide resolved
golang.org/x/sys v0.0.0-20210113181707-4bcb84eeeb78 // indirect
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.To add fiber support might have to add fiber itself into the go module file, since fiber server is based on the fasthttp, which is different from the golang's original net/http package.
Please see following reference for performance benchmarking.
fasthttp: (https://github.com/valyala/fasthttp)
fiber: (https://github.com/gofiber/fiber)
2. It would be better to keep the version of beego used in testing indirectly to keep the test working.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know your point. I remove all packages from go.mod since renaming the example to _example. So we don't need all the framework package if you want to use the package.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the reference: #81

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any feedbacks?

gofight.go Outdated Show resolved Hide resolved
@appleboy appleboy merged commit ec4039c into appleboy:master Jun 27, 2021
@appleboy
Copy link
Owner

I remove the fiber package since fiber doesn't support ServeHTTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants