-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Beego_test and add fiberEngine Test. #86
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba898da
Fix Beego_test and add fiberEngine Test.
ralic a5c795e
Add comment to for RunX
ralic 37041ca
Revised for pull request #86
ralic e99af8a
Add test for SetPath and print querystring in debug.
ralic 9488772
Reverse beego_test.go
ralic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package example | ||
|
||
import ( | ||
"fmt" | ||
"github.com/gofiber/fiber/v2" | ||
) | ||
|
||
// FiberEngine is fiber web server and handlers routes | ||
func FiberEngine() *fiber.App { | ||
// Fiber instance | ||
e := fiber.New() | ||
// Routes | ||
e.Get("/helloCouple", fiberRoute) | ||
return e | ||
} | ||
|
||
func fiberRoute(c *fiber.Ctx) error { | ||
names := c.Context().QueryArgs().PeekMulti("names") | ||
ages := c.Context().QueryArgs().PeekMulti("ages") | ||
msg := "" | ||
for i := range names { | ||
msg += fmt.Sprintf("God Love the World ! 👴 %s is %s years old~\n", string(names[i]), string(ages[i])) | ||
} | ||
c.Status(200).SendString(msg) | ||
// =>God Love the World ! 👴 john is 75 years old~ | ||
// God Love the World ! 👴 mary is 25 years old~ | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package example | ||
|
||
import ( | ||
"github.com/appleboy/gofight/v2" | ||
"github.com/stretchr/testify/assert" | ||
"net/http" | ||
"testing" | ||
) | ||
|
||
func TestFiberEngine(t *testing.T) { | ||
|
||
tests := []struct { | ||
name string | ||
path string | ||
want string | ||
}{ | ||
{ | ||
name: "TestHelloWorld", | ||
path: "/", | ||
want: `God Love the World ! 👴 john is 75 years old~ | ||
God Love the World ! 👴 mary is 25 years old~ | ||
`, | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
r := gofight.New() | ||
r.GET(tt.path). | ||
SetPath("helloCouple"). | ||
SetQueryD(gofight.D{ | ||
"names": []string{"john", "mary"}, | ||
"ages": []string{"75", "25"}, | ||
}). | ||
SetDebug(true). | ||
RunX(FiberEngine(), func(res gofight.HTTPResponse, req gofight.HTTPRequest) { | ||
assert.Equal(t, tt.want, res.Body.String()) | ||
assert.Equal(t, http.StatusOK, res.Code) | ||
}) | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.To add fiber support might have to add fiber itself into the go module file, since fiber server is based on the fasthttp, which is different from the golang's original net/http package.
Please see following reference for performance benchmarking.
fasthttp: (https://github.com/valyala/fasthttp)
fiber: (https://github.com/gofiber/fiber)
2. It would be better to keep the version of beego used in testing indirectly to keep the test working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know your point. I remove all packages from
go.mod
since renaming theexample
to_example
. So we don't need all the framework package if you want to use the package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the reference: #81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any feedbacks?