Add media events back to TestUtils.Simulate (facebook#12010)

The TestUtils lost media events when they were pulled out of the topLevelTypes constant. This commit adds them back by concatenating the media event keys to the list of top level types.
appsforartists · Jan 12, 2018 · 3766a01 · 3766a01
1 parent 73fa26a
commit 3766a01
Show file tree

Hide file tree

Showing 3 changed files with 167 additions and 2 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactTestUtils-test.js b/packages/react-dom/src/__tests__/ReactTestUtils-test.js
@@ -35,6 +35,14 @@ describe('ReactTestUtils', () => {
     ReactTestUtils = require('react-dom/test-utils');
   });
 
+  it('Simulate should have locally attached media events', () => {
+    expect(Object.keys(ReactTestUtils.Simulate).sort()).toMatchSnapshot();
+  });
+
+  it('SimulateNative should have locally attached media events', () => {
+    expect(Object.keys(ReactTestUtils.SimulateNative).sort()).toMatchSnapshot();
+  });
+
   it('gives Jest mocks a passthrough implementation with mockComponent()', () => {
     class MockedComponent extends React.Component {
       render() {

diff --git a/packages/react-dom/src/__tests__/__snapshots__/ReactTestUtils-test.js.snap b/packages/react-dom/src/__tests__/__snapshots__/ReactTestUtils-test.js.snap
@@ -0,0 +1,152 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`ReactTestUtils Simulate should have locally attached media events 1`] = `
+Array [
+  "abort",
+  "animationEnd",
+  "animationIteration",
+  "animationStart",
+  "beforeInput",
+  "blur",
+  "canPlay",
+  "canPlayThrough",
+  "cancel",
+  "change",
+  "click",
+  "close",
+  "compositionEnd",
+  "compositionStart",
+  "compositionUpdate",
+  "contextMenu",
+  "copy",
+  "cut",
+  "doubleClick",
+  "drag",
+  "dragEnd",
+  "dragEnter",
+  "dragExit",
+  "dragLeave",
+  "dragOver",
+  "dragStart",
+  "drop",
+  "durationChange",
+  "emptied",
+  "encrypted",
+  "ended",
+  "error",
+  "focus",
+  "input",
+  "invalid",
+  "keyDown",
+  "keyPress",
+  "keyUp",
+  "load",
+  "loadStart",
+  "loadedData",
+  "loadedMetadata",
+  "mouseDown",
+  "mouseEnter",
+  "mouseLeave",
+  "mouseMove",
+  "mouseOut",
+  "mouseOver",
+  "mouseUp",
+  "paste",
+  "pause",
+  "play",
+  "playing",
+  "progress",
+  "rateChange",
+  "reset",
+  "scroll",
+  "seeked",
+  "seeking",
+  "select",
+  "stalled",
+  "submit",
+  "suspend",
+  "timeUpdate",
+  "toggle",
+  "touchCancel",
+  "touchEnd",
+  "touchMove",
+  "touchStart",
+  "transitionEnd",
+  "volumeChange",
+  "waiting",
+  "wheel",
+]
+`;
+
+exports[`ReactTestUtils SimulateNative should have locally attached media events 1`] = `
+Array [
+  "abort",
+  "animationEnd",
+  "animationIteration",
+  "animationStart",
+  "blur",
+  "canPlay",
+  "canPlayThrough",
+  "cancel",
+  "change",
+  "click",
+  "close",
+  "compositionEnd",
+  "compositionStart",
+  "compositionUpdate",
+  "contextMenu",
+  "copy",
+  "cut",
+  "doubleClick",
+  "drag",
+  "dragEnd",
+  "dragEnter",
+  "dragExit",
+  "dragLeave",
+  "dragOver",
+  "dragStart",
+  "drop",
+  "durationChange",
+  "emptied",
+  "encrypted",
+  "ended",
+  "error",
+  "focus",
+  "input",
+  "keyDown",
+  "keyPress",
+  "keyUp",
+  "load",
+  "loadStart",
+  "loadedData",
+  "loadedMetadata",
+  "mouseDown",
+  "mouseMove",
+  "mouseOut",
+  "mouseOver",
+  "mouseUp",
+  "paste",
+  "pause",
+  "play",
+  "playing",
+  "progress",
+  "rateChange",
+  "scroll",
+  "seeked",
+  "seeking",
+  "selectionChange",
+  "stalled",
+  "suspend",
+  "textInput",
+  "timeUpdate",
+  "toggle",
+  "touchCancel",
+  "touchEnd",
+  "touchMove",
+  "touchStart",
+  "transitionEnd",
+  "volumeChange",
+  "waiting",
+  "wheel",
+]
+`;
diff --git a/packages/react-dom/src/test-utils/ReactTestUtils.js b/packages/react-dom/src/test-utils/ReactTestUtils.js
@@ -18,7 +18,7 @@ import {
 import SyntheticEvent from 'events/SyntheticEvent';
 import invariant from 'fbjs/lib/invariant';
 
-import {topLevelTypes} from '../events/BrowserEventConstants';
+import {topLevelTypes, mediaEventTypes} from '../events/BrowserEventConstants';
 
 const {findDOMNode} = ReactDOM;
 const {
@@ -456,7 +456,12 @@ function makeNativeSimulator(eventType) {
   };
 }
 
-Object.keys(topLevelTypes).forEach(function(eventType) {
+const eventKeys = [].concat(
+  Object.keys(topLevelTypes),
+  Object.keys(mediaEventTypes),
+);
+
+eventKeys.forEach(function(eventType) {
   // Event type is stored as 'topClick' - we transform that to 'click'
   const convenienceName =
     eventType.indexOf('top') === 0