fix: loading state for pull

[brayn003]

Description

Fixes issue of missing loader when pulling changes from remote

Fixes #36273
Fixes #31308

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10899771670
Commit: 1ebb4a5
Cypress dashboard.
Tags: @tag.Git
Spec:
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js

List of identified flaky tests.

---

Tue, 17 Sep 2024 09:25:22 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Introduced a new selector to track the progress of pull operations.
  • Enhanced loading state logic to reflect multiple concurrent Git operations.

• Bug Fixes

  • Improved accuracy of loading state for pull actions and discard operations.

[coderabbitai]

Walkthrough

The changes in the QuickGitActions component primarily focus on enhancing state management for Git operations. A new selector, getIsPullingProgress, has been introduced to monitor pull operation progress. The existing variable isPullInProgress has been updated to utilize this selector, and the loading state for pull actions has been expanded to include additional conditions. This adjustment allows the component to provide a more accurate representation of loading states during concurrent operations.

Changes

Files	Change Summary
app/client/src/pages/Editor/gitSync/QuickGitActions/index.tsx	Added getIsPullingProgress selector, updated isPullInProgress to use this selector, and modified showPullLoadingState to include isDiscardInProgress.

Assessment against linked issues

Objective	Addressed	Explanation
Missing loader for git pull (#36273)	✅

Suggested labels

IDE Product

Poem

In the land of code where Git does play,
A loader now dances, brightening the way.
With progress tracked and states aligned,
Pull operations smoother, joyfully designed!
So let’s cheer for changes, both clever and bright,
In the realm of the editor, all feels just right! 🎉

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66c815f and 1ebb4a5.

Files selected for processing (1)

• app/client/src/pages/Editor/gitSync/QuickGitActions/index.tsx (2 hunks)

Additional comments not posted (2)

app/client/src/pages/Editor/gitSync/QuickGitActions/index.tsx (2)

307-311: Great work on improving the loading state logic! 👍

By considering the isDiscardInProgress, isPullInProgress, and isFetchingGitStatus conditions, the showPullLoadingState variable now accurately reflects the loading state based on multiple concurrent Git operations. This enhancement ensures that the user interface provides appropriate feedback during complex scenarios.

---

308-308: Excellent use of the getIsPullingProgress selector! 🎉

Updating the isPullInProgress variable to utilize the getIsPullingProgress selector is a smart move. By leveraging a centralized selector for determining the pull operation progress, you've enhanced code modularity and maintainability. This approach ensures that the logic for tracking pull progress is consistent across the codebase and can be easily updated in a single location.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.