chore: Rename app-viewers to widgets-blocks #37553
Conversation
sharat87
requested review from
a team and
AnaghHegde
and removed request for
a team
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
🔇 Additional comments (1)
CODEOWNERS (1)
31-31: Verify ownership overlap with UI Builders Pod.
There appears to be an overlap in ownership for the propertyControls directory:
- Line 31:
app/client/src/components/propertyControls/*→@appsmithorg/widgets-blocks - Line 89:
app/client/src/components/propertyControls/*→@appsmithorg/anvil-team
Please clarify the intended ownership for this directory.
Also applies to: 89-89
| app/client/src/widgets/* @appsmithorg/widgets-blocks | ||
| app/client/src/components/propertyControls/* @appsmithorg/widgets-blocks | ||
| app/client/src/sagas/OneClickBindingSaga.ts @appsmithorg/widgets-blocks | ||
| app/client/src/WidgetQueryGenerators/* @appsmithorg/widgets-blocks | ||
| app/client/src/components/editorComponents/WidgetQueryGeneratorForm/* @appsmithorg/widgets-blocks | ||
| app/client/src/pages/AppViewer/* @appsmithorg/widgets-blocks |
There was a problem hiding this comment.
💡 Codebase verification
There are overlapping ownership assignments that need to be resolved:
-
app/client/src/widgets/*has conflicting ownership:- Line 30: @appsmithorg/widgets-blocks
- Lines 87-92: @appsmithorg/anvil-team (specific files)
- Line 24: @appsmithorg/wds-team & @appsmithorg/anvil-team (wds subdirectory)
-
app/client/src/components/propertyControls/*has conflicting ownership:- Line 31: @appsmithorg/widgets-blocks
- Line 59: @appsmithorg/anvil-team
Please clarify the ownership hierarchy and resolve these conflicts to prevent confusion in code review assignments.
🔗 Analysis chain
LGTM! Ownership reassignment is consistent with PR objectives.
The ownership transfer from @appsmithorg/app-viewers to @appsmithorg/widgets-blocks is properly implemented for all widget-related paths.
Let's verify there are no ownership conflicts with other teams:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for paths that might have multiple owners
# Test: Look for duplicate path definitions
rg -n "^app/client/src/widgets/\*" CODEOWNERS
rg -n "^app/client/src/components/propertyControls/\*" CODEOWNERS
rg -n "^app/client/src/pages/AppViewer/\*" CODEOWNERS
Length of output: 4973
Script:
#!/bin/bash
# Let's try a different approach to check for ownership conflicts
# 1. Get all lines containing the paths we're interested in
grep -n "app/client/src/widgets\|app/client/src/components/propertyControls\|app/client/src/pages/AppViewer" CODEOWNERS
# 2. Also check for any other team assignments in these directories
grep -n "widgets-blocks\|app-viewers" CODEOWNERS
Length of output: 1358
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
@appsmithorg/app-viewersto@appsmithorg/widgets-blocks.