fix: Renaming tests with error expectations #38021
Conversation
hetunandu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe changes in this pull request involve modifications to the Cypress test cases and support files related to API name validation and renaming functionality. The test for renaming an API has been streamlined by consolidating multiple calls into a single method. Additionally, the support files have been updated to enhance error handling and modularity, including the introduction of new interfaces and adjustments to existing method signatures. These updates improve the clarity and efficiency of the code without introducing new functionalities. Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/client/cypress/support/Pages/AggregateHelper.ts (1)
Line range hint
235-258: Consider enhancing error handling structureWhile the error handling addition is good, consider refactoring to improve readability and maintainability.
- if (args.willFailError) { - this.AssertContains(args.willFailError, "exist", ".ads-v2-tooltip"); - cy.get(textInputLocator).blur(); - } else { - cy.get(textInputLocator).blur(); - this.PressEnter(); - } + cy.get(textInputLocator).blur(); + + if (args.willFailError) { + this.AssertContains(args.willFailError, "exist", ".ads-v2-tooltip"); + return; + } + + this.PressEnter();
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/client/cypress/support/Pages/AggregateHelper.ts(7 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/support/Pages/AggregateHelper.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (3)
app/client/cypress/support/Pages/AggregateHelper.ts (3)
19-26: Well-structured interfaces for test automation!
The new interfaces SubActionParams and SelectAndValidateParams are well-defined with proper TypeScript types and optional properties.
271-277: LGTM: Consistent method signature update
The RenameQuery method has been properly updated to handle error cases, maintaining consistency with the rename method changes.
952-952: Skip: Formatting change
Description
Update renaming tests for tabs when error expectations need to be asserted
Automation
/ok-to-test tags="@tag.IDE, @tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12199824922
Commit: 47dddde
Cypress dashboard.
Tags:
@tag.IDE, @tag.DatasourceSpec:
Fri, 06 Dec 2024 14:30:54 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Bug Fixes
New Features
Refactor
Style