fix : Updating EntityBottomBar_spec.ts with a query which doesnt depe… #38057
Conversation
…nd on the field id
trishaanand
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe changes in this pull request involve modifications to the test cases within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (2)
Line range hint
77-77: Remove _.agHelper.Sleep() usageReplace Sleep with proper Cypress wait commands that wait for specific conditions rather than arbitrary timeouts.
- _.agHelper.Sleep(1000); + cy.wait("@postExecute").its("response.statusCode").should("eq", 200);
Line range hint
156-158: Improve type safety in alias handlingAvoid using 'as any' type assertion. Instead, properly type the alias value.
- cy.get("@dsName").then(($dsName) => { - _.dataSources.DeleteDatasourceFromWithinDS($dsName as any); - }); + cy.get<string>("@dsName").then((dsName) => { + _.dataSources.DeleteDatasourceFromWithinDS(dsName); + });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (2)
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (2)
Line range hint 8-162: Well-structured test cases
The test cases follow good practices:
- Multiple assertions are used
- No it.only or after/afterEach hooks
- Logical flow of test steps
143-143: Query change aligns with PR objectives
The removal of ORDER BY id makes the test more resilient by eliminating dependency on the 'id' field, which addresses the issue of test failures due to mock database changes.
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
This PR has been closed because of inactivity. |
…nd on the field id
The data for mock db keeps changing. Removing dependency on id field to ensure that we fail less often. This is a temporary fix while we move away from external dependency of mockdb
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/test IDE
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12237445904
Commit: e1b7902
Cypress dashboard.
Tags:
@tag.IDESpec:
Mon, 09 Dec 2024 14:48:21 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit