Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif master branch commits up to the point of v1.5.1 tag on v1 branch #106

Merged
merged 83 commits into from
Aug 16, 2021

Conversation

@DrDaveD DrDaveD requested review from kmuriki and ikaneshiro August 10, 2021 20:31
@DrDaveD
Copy link
Contributor Author

DrDaveD commented Aug 11, 2021

The CI test is still pending. I'm going to try closing & reopening to kick that.

@DrDaveD DrDaveD closed this Aug 11, 2021
@DrDaveD DrDaveD reopened this Aug 11, 2021
@DrDaveD
Copy link
Contributor Author

DrDaveD commented Aug 16, 2021

The golangci-lint check is failing because we are using v1.14.0 and sylabs is using the golangci/golangci-lint:v1.41-alpine docker container, which contains v1.14.1.

@DrDaveD DrDaveD force-pushed the merge-v2-through-151 branch 4 times, most recently from 035b564 to 52c1742 Compare August 16, 2021 15:01
@DrDaveD DrDaveD force-pushed the merge-v2-through-151 branch from 52c1742 to 7e0f04c Compare August 16, 2021 15:02
@codecov-commenter
Copy link

Codecov Report

Merging #106 (7e0f04c) into master (acaf90f) will increase coverage by 3.87%.
The diff coverage is 75.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   65.08%   68.96%   +3.87%     
==========================================
  Files          12       27      +15     
  Lines        1395     1611     +216     
==========================================
+ Hits          908     1111     +203     
- Misses        310      341      +31     
+ Partials      177      159      -18     
Flag Coverage Δ
unittests 68.96% <75.52%> (+3.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/app/siftool/file.go 42.85% <ø> (ø)
pkg/integrity/digest.go 93.10% <ø> (ø)
pkg/sif/fmt.go 69.62% <ø> (-3.60%) ⬇️
pkg/sif/lookup.go 100.00% <ø> (+34.82%) ⬆️
pkg/sif/sif.go 30.58% <38.09%> (+5.58%) ⬆️
pkg/sif/descriptor.go 53.57% <53.57%> (ø)
pkg/sif/create.go 50.52% <55.55%> (-0.19%) ⬇️
pkg/integrity/metadata.go 51.85% <66.66%> (-1.36%) ⬇️
pkg/sif/load.go 50.84% <73.33%> (-2.38%) ⬇️
pkg/integrity/select.go 68.00% <77.41%> (+5.11%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaf90f...7e0f04c. Read the comment docs.

@DrDaveD
Copy link
Contributor Author

DrDaveD commented Aug 16, 2021

Successfully converted to using the golangci/golangci-lint-action github action which accepts a major.minor version instead of major.minor.patch.

@DrDaveD DrDaveD merged commit b8e7868 into apptainer:master Aug 16, 2021
@DrDaveD DrDaveD deleted the merge-v2-through-151 branch August 16, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve options for CreateContainer Refactor cmd and pkg's siftool
4 participants