Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Arguments for CreateContainer #31

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Functional Arguments for CreateContainer #31

merged 4 commits into from
Jul 6, 2021

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Jun 22, 2021

Use functional arguments for CreateContainer. Define SpecVersion type. Switch several header const values to be non-exported.

Closes #28

@tri-adam tri-adam added the v2 Affects v2 API label Jun 22, 2021
@tri-adam tri-adam self-assigned this Jun 22, 2021
@tri-adam tri-adam removed the v2 Affects v2 API label Jun 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #31 (36b1705) into master (c23314b) will decrease coverage by 0.27%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   66.86%   66.58%   -0.28%     
==========================================
  Files          25       25              
  Lines        1672     1685      +13     
==========================================
+ Hits         1118     1122       +4     
- Misses        366      374       +8     
- Partials      188      189       +1     
Impacted Files Coverage Δ
pkg/sif/lookup.go 65.00% <0.00%> (ø)
pkg/sif/load.go 53.22% <50.00%> (ø)
pkg/sif/create.go 50.00% <56.09%> (-0.72%) ⬇️
internal/app/siftool/modif.go 83.33% <100.00%> (+2.68%) ⬆️
pkg/sif/sif.go 28.23% <100.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23314b...36b1705. Read the comment docs.

Adam Hughes added 3 commits July 6, 2021 15:23
@tri-adam tri-adam marked this pull request as ready for review July 6, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional Options for CreateContainer
3 participants