Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user labels based on design review #503

Merged
merged 13 commits into from
Aug 21, 2023

Commits on Apr 2, 2023

  1. fix the padding-top style

    kabhamo committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d996e62 View commit details
    Browse the repository at this point in the history
  2. Merge commit '6039139a831aa9c8d9f9331eeb1f927163127680' into fix-5295…

    …-code-component-style-fix
    kabhamo committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    1bae4b3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Configuration menu
    Copy the full SHA
    134ca9c View commit details
    Browse the repository at this point in the history
  2. fix: change css property

    kabhamo committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2ce827e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    fc922e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f309bb2 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. fixed incorrect array being used in comparison

    Use `symmetricDifference` instead of `difference`.
    - `difference` only returns values that are present in the edited attributes, but not in the originally fetched attribute vales. This always ends up returning an empty array.
    - I used `symmetricDifference` as it returns an intersection of `difference` from both sides and works perfectly for this use case, as the original attributes never change.
    safwanyp committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    da00454 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. use deep clone instead of reference copy

    - Original code creates a reference copy of `$doc` into `$work` which means that editing values of `$work` changes the values in `$doc`.
    - Fix this behaviour by creating a deep clone of `$doc` into `$work`, so underlying values aren't cross-referenced.
    safwanyp committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    399ec90 View commit details
    Browse the repository at this point in the history
  2. Simplify initialization of editable attributes for clarity

    Instead of cramming all the steps for correct deep cloning, I split the implementation into 4 distinct steps:
    - define they keys to exclude
    - filtering the keys
    - reduce filtered keys into an object
    - returning a writable deep clone
    safwanyp committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5ad0349 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge pull request #377 from kabhamo/fix-5295-code-component-style-fix

    Fix 5295 code component style fix
    christyjacob4 authored Aug 11, 2023
    3 Configuration menu
    Copy the full SHA
    f2b170c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #495 from safwanyp/fix-5476-user-unable-to-update-…

    …document-after-array-value-deletion
    
    fixed issue that didn't allow a user to update a document when deleting elements in an array attribute
    christyjacob4 authored Aug 11, 2023
    3 Configuration menu
    Copy the full SHA
    2a0628a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Update user labels based on design review:

    1. Fix typo in labels placeholder
    2. Reorder tags and helper text
    stnguyen90 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    17d0594 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch '1.4.x' of github.com:appwrite/console into fix-user-lab…

    …els-design-corrections
    ArmanNik committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8cea7d9 View commit details
    Browse the repository at this point in the history