🐛 Bug Report: Flutter Web authentication bad URLCallback - doesn't work

[netapy]

👟 Reproduction steps

My app uses flutter (web, Android, iOS) for the front-end and Appwrite for the back end.
I use OAuth to let my users log in.

There is a bug with the flutter_web_auth_2 2.0.3 dependency that Appwrite uses.
To log in to my service, this function is called in my client :

if (kIsWeb) {
  await globals.account.createOAuth2Session(provider: provider, success: "https://banquise.app", failure: "https://banquise.app");
} else {
  await globals.account.createOAuth2Session(provider: provider);
}

But the success and failure callbackUrls give an error because of this check in flutter_web_auth_2 2.0.3 :
https://github.com/ThexXTURBOXx/flutter_web_auth_2/blob/157285f9230cfc1815ed5b2bb6a58b1dabc277d5/flutter_web_auth_2/lib/flutter_web_auth_2.dart#L35-L44
Which verifies if the url scheme corresponds to r'^[a-z][a-z0-9+.-]*$'.

It doesn't, because it's a URL with https://... so not only alphanumerical characters with . and -.

Removing the https:// raises an error in Appwrite saying the callback url is wrong.

👍 Expected behavior

It should not raise an exception for the success and failure url scheme.

👎 Actual Behavior

It raises an exception.

🎲 Appwrite version

Version 1.2.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

@lohanidamodar would you be able to help with this?

[stnguyen90]

I'm pretty sure this was working before, but the upgrade of flutter_web_auth_2 to 2.x probably broke it.

[lohanidamodar]

@netapy I'll look into it.

[hemangjoshi37a]

I have similar issue #116 Have you found any solutions yet?

[netapy]

@hemangjoshi37a , for now I just use a forked version of flutter_web_auth_2 I made : https://github.com/netapy/flutter_web_auth_2_oauthlinkfix , just link to this repository instead of the dependency, if you can’t wait for the fix.

[lohanidamodar]

@netapy @hemangjoshi37a the fix is already merged and should be released soon

[netapy]

Thanks for handling it.
Is the fix only in the Flutter Client package ?
How long will it take to publish ?
Sorry to push but I can't update my app with my custom fix.

[lohanidamodar]

@netapy version 8.2.1 should resolve this issue
https://pub.dev/packages/appwrite