fix-flutter-oauth2-under-windows #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohanidamodar
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
@Mabenan you confirm that this resolves the issue? I like the approach, it doesn’t modify the external facing API. Looks good.
lohanidamodar
requested review from
codercatdev,
wess and
stnguyen90
and removed request for
wess and
codercatdev
I've tested it and it looks good |
2 tasks
stnguyen90
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the broken createOAuth2Session under windows in the flutter sdk. This is discussed in detail here appwrite/sdk-for-flutter#96.
Test Plan
Create a minimal APP with the flutter SDK and try to sign in with OAuth2.
The success URL must look something like this
http://localhost:{free_windows_port}/v1/auth/oauth2/success
Related PRs and Issues
96
Have you read the Contributing Guidelines on issues?
YES