Add cmake #13
Merged
Add cmake #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CMake build support to a kernel framework (kf) project, enabling compilation and testing of the codebase. The changes introduce CMake configuration files, test infrastructure, and fix compilation issues to make the project buildable.
- Adds comprehensive CMake build system with WDK integration for kernel development
- Implements a hex encoding/decoding test suite to validate build functionality
- Fixes compilation issues by removing assertions and adding necessary includes
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Root CMake configuration with compiler flags and WDK setup |
| include/CMakeLists.txt | Library target definition for the kf framework |
| test/CMakeLists.txt | Test driver configuration |
| test/pch.h | Precompiled header with STL compatibility shims for kernel mode |
| test/HexTest.cpp | Test cases for hex encoding/decoding functionality |
| include/kf/Hex.h | Enhanced hex utilities with Unicode support and magic number elimination |
| include/kf/ScopedBuffer.h | Removed assertions from getter methods |
| .gitmodules | Git submodule configuration for test dependencies |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
SergiusTheBest
requested changes
Jul 23, 2025
SergiusTheBest
requested changes
Jul 24, 2025
SergiusTheBest
approved these changes
Jul 25, 2025
Member
|
@belyshevdenis Hurrah! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake
Add Hex test to prove buildability
Fix compilation and linkage