Map: implement tests #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing and benchmarking infrastructure for the kf library's Map implementation, along with improvements to the Hex utility and supporting STL infrastructure for kernel-mode development.
- Introduces test framework integration with kmtest and comprehensive Map functionality tests
- Adds performance benchmarking capabilities for Map operations
- Enhances Hex utility with Unicode string support and improves code maintainability
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/MapTest.cpp | Comprehensive test suite covering Map insertion, finding, iteration, and bounds operations |
| test/HexTest.cpp | Test cases for Hex encoding/decoding with Unicode strings |
| kfbenchmark/MapBenchmark.cpp | Performance benchmark for Map find operations with large datasets |
| include/kf/Map.h | New Map class implementation with kernel-mode memory management |
| include/kf/Hex.h | Enhanced Hex utility with Unicode support and improved maintainability |
| include/kf/stl/BuildHelpers.h | Kernel-mode STL compatibility layer with error handling |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SergiusTheBest
requested changes
Jul 30, 2025
SergiusTheBest
requested changes
Jul 30, 2025
SergiusTheBest
requested changes
Jul 30, 2025
Closed
SergiusTheBest
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on:
#13
#11