Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.goxc.json: list os/arch explicitly to avoid darwin/386 #947

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

peat-psuwit
Copy link
Contributor

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Go 1.15 drops support for darwin/386 GOOS/GOARCH pair [1]. So, we have
to skip this pair, and thus cannot use simple os multiply arch anymore.
Switch to goxc's BuildConstraints config, which uses the same syntax as
Go's build constraint header [2].

[1] golang/go#37610
[2] https://golang.org/cmd/go/#hdr-Build_constraints

Fixes #943

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #947 (7db7e3c) into master (cbf0416) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files          54       54           
  Lines        5928     5928           
=======================================
  Hits         3633     3633           
  Misses       1770     1770           
  Partials      525      525           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf0416...7db7e3c. Read the comment docs.

@Smarre
Copy link

Smarre commented Mar 26, 2021

Looks good to me.

Go 1.15 drops support for darwin/386 GOOS/GOARCH pair [1]. So, we have
to skip this pair, and thus cannot use simple os multiply arch anymore.
Switch to goxc's BuildConstraints config, which uses the same syntax as
Go's build constraint header [2].

[1] golang/go#37610
[2] https://golang.org/cmd/go/#hdr-Build_constraints
@peat-psuwit peat-psuwit force-pushed the fix-release-darwin-386 branch from db34883 to 7db7e3c Compare March 26, 2021 10:42
@mariogrip
Copy link

ping @lbolla

@lbolla lbolla merged commit f9d08e1 into aptly-dev:master Apr 29, 2021
@peat-psuwit peat-psuwit deleted the fix-release-darwin-386 branch June 10, 2021 16:34
@randombenj randombenj added this to the 1.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported darwin/386 release
5 participants