[release-1.15] Deactivate broken package overrides #13797

wrwg · 2024-06-24T18:15:55Z

Description

Renaming the tomls for deactivating the tests

Type of Change

Which Components or Systems Does This Change Impact?

Renaming the tomls for deactivating the tests

trunk-io · 2024-06-24T18:15:59Z

⏱️ 4h 13m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-smoke-tests	41m	🟩
execution-performance / single-node-performance	28m	🟩
rust-targeted-unit-tests	27m	⬜ 🟩
rust-move-tests	17m	⬜ 🟩
rust-images / rust-all	17m	🟩
forge-framework-upgrade-test / forge	16m	🟩
rust-move-unit-coverage	15m	🟩
forge-e2e-test / forge	13m	🟩
forge-compat-test / forge	13m	🟩
rust-lints	12m	⬜ 🟩
execution-performance / test-target-determinator	11m	🟩
test-target-determinator	11m	🟩
rust-build-cached-packages	8m	🟩
cli-e2e-tests / run-cli-tests	6m	🟩
run-tests-main-branch	5m	⬜ 🟩
check	4m	🟩
check-dynamic-deps	3m	🟩 🟩
general-lints	3m	⬜ 🟩
node-api-compatibility-tests / node-api-compatibility-tests	1m	🟩
semgrep/ci	42s	🟩 🟩
file_change_determinator	25s	🟩 🟩
file_change_determinator	20s	🟩 🟩
permission-check	11s	🟩 🟩
file_change_determinator	10s	🟩
permission-check	5s	🟩 🟩
permission-check	5s	🟩 🟩
permission-check	4s	🟩 🟩
permission-check	3s	🟩
determine-docker-build-metadata	3s	🟩

🚨 9 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
execution-performance / test-target-determinator	11m	4m
test-target-determinator	11m	4m
execution-performance / single-node-performance	28m	11m
rust-targeted-unit-tests	26m	13m
rust-move-tests	16m	9m
rust-lints	10m	6m
rust-build-cached-packages	8m	5m
rust-images / rust-all	17m	13m
rust-move-unit-coverage	15m	12m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov · 2024-06-24T18:31:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aptos-release-v1.15@650f548). Learn more about missing BASE report.

Additional details and impacted files

@@                  Coverage Diff                   @@
##             aptos-release-v1.15   #13797   +/-   ##
======================================================
  Coverage                       ?    58.5%           
======================================================
  Files                          ?      823           
  Lines                          ?   198453           
  Branches                       ?        0           
======================================================
  Hits                           ?   116165           
  Misses                         ?    82288           
  Partials                       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-24T18:47:23Z

✅ Forge suite `compat` success on `a68e71c05caebf01504d4499110f3fba213fb53d` ==> `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 7289.301287524907 txn/s, latency: 4202.539565634421 ms, (p50: 3300 ms, p90: 4100 ms, p99: 29600 ms), latency samples: 291920
2. Upgrading first Validator to new version: e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2990.0372294104072 txn/s, latency: 10395.496389776357 ms, (p50: 9700 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 125200
3. Upgrading rest of first batch to new version: e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3307.316127828805 txn/s, latency: 9367.541779149913 ms, (p50: 9400 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 139280
4. upgrading second batch to new version: e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1730.8890183231706 txn/s, latency: 16784.740898004435 ms, (p50: 19000 ms, p90: 29300 ms, p99: 30700 ms), latency samples: 90200
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8 passed
Test Ok

github-actions · 2024-06-24T18:48:07Z

✅ Forge suite `realistic_env_max_load` success on `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`

two traffics test: inner traffic : committed: 8582.517825741555 txn/s, latency: 4570.130365731869 ms, (p50: 4500 ms, p90: 5700 ms, p99: 9300 ms), latency samples: 3704900
two traffics test : committed: 100.07365201253523 txn/s, latency: 2070.6704545454545 ms, (p50: 2000 ms, p90: 2300 ms, p99: 2900 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.219, avg: 0.213", "QsPosToProposal: max: 0.273, avg: 0.250", "ConsensusProposalToOrdered: max: 0.323, avg: 0.290", "ConsensusOrderedToCommit: max: 0.387, avg: 0.361", "ConsensusProposalToCommit: max: 0.676, avg: 0.651"]
Max round gap was 1 [limit 4] at version 1789994. Max no progress secs was 4.8034363 [limit 15] at version 1789994.
Test Ok

github-actions · 2024-06-24T18:50:45Z

✅ Forge suite `framework_upgrade` success on `a68e71c05caebf01504d4499110f3fba213fb53d` ==> `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8 (PR)
Upgrade the nodes to version: e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 999.4159278959838 txn/s, submitted: 1002.7443557197937 txn/s, failed submission: 3.3284278238098928 txn/s, expired: 3.3284278238098928 txn/s, latency: 3207.4503108348135 ms, (p50: 2100 ms, p90: 6400 ms, p99: 9900 ms), latency samples: 90080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1051.2748416078848 txn/s, submitted: 1053.7415701184834 txn/s, failed submission: 2.466728510598706 txn/s, expired: 2.466728510598706 txn/s, latency: 2884.2742214163823 ms, (p50: 2100 ms, p90: 5400 ms, p99: 10000 ms), latency samples: 93760
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8 passed
Upgrade the remaining nodes to version: e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1138.5935490658728 txn/s, submitted: 1140.8375253155098 txn/s, failed submission: 2.2439762496371163 txn/s, expired: 2.2439762496371163 txn/s, latency: 2701.310514387071 ms, (p50: 2100 ms, p90: 4500 ms, p99: 9600 ms), latency samples: 101480
Test Ok

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13937) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13935) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13936) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

[release-1.15] Deactivate broken package overrides

e48a713

Renaming the tomls for deactivating the tests

wrwg requested review from runtian-zhou, vgao1996 and fEst1ck June 24, 2024 18:15

vgao1996 approved these changes Jun 24, 2024

View reviewed changes

wrwg enabled auto-merge (squash) June 24, 2024 18:17

runtian-zhou approved these changes Jun 24, 2024

View reviewed changes

fEst1ck approved these changes Jun 24, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

wrwg merged commit 4e1ee9b into aptos-release-v1.15 Jun 24, 2024
82 of 89 checks passed

wrwg deleted the wrwg/fix-1.15 branch June 24, 2024 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-1.15] Deactivate broken package overrides #13797

[release-1.15] Deactivate broken package overrides #13797

wrwg commented Jun 24, 2024

trunk-io bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 24, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jun 24, 2024

[release-1.15] Deactivate broken package overrides #13797

[release-1.15] Deactivate broken package overrides #13797

Conversation

wrwg commented Jun 24, 2024

Description

Type of Change

Which Components or Systems Does This Change Impact?

trunk-io bot commented Jun 24, 2024 • edited Loading

codecov bot commented Jun 24, 2024

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 24, 2024

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8

github-actions bot commented Jun 24, 2024

✅ Forge suite realistic_env_max_load success on e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8

github-actions bot commented Jun 24, 2024

✅ Forge suite framework_upgrade success on a68e71c05caebf01504d4499110f3fba213fb53d ==> e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8

trunk-io bot commented Jun 24, 2024 •

edited

Loading

✅ Forge suite `compat` success on `a68e71c05caebf01504d4499110f3fba213fb53d` ==> `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`

✅ Forge suite `realistic_env_max_load` success on `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`

✅ Forge suite `framework_upgrade` success on `a68e71c05caebf01504d4499110f3fba213fb53d` ==> `e48a7135c3feded78a5ca2c7bd97ef44b9ab64d8`