[AptosFramework] migrate forge tests #260

zekun000 · 2022-03-21T06:36:48Z

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/aptos-labs/aptos-core/tree/main/developer-docs-site, and link to your PR here.)

If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for the release.
What workarounds and alternative we have if we do not push the PR.

netlify · 2022-03-21T06:36:52Z

✅ Deploy Preview for aptos-developer-docs ready!

Name	Link
🔨 Latest commit	`1de250f`
🔍 Latest deploy log	https://app.netlify.com/sites/aptos-developer-docs/deploys/623a21299c8c090009170444
😎 Deploy Preview	https://deploy-preview-260--aptos-developer-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zekun000 · 2022-03-21T16:57:01Z

/canary

zekun000 · 2022-03-21T16:58:19Z

/canary

aptos-bot · 2022-03-21T17:26:58Z

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/4908
Forge Test Result: all up : 1982 TPS, 2205 ms latency, 3050 ms p99 latency,no expired txns

aptos-bot · 2022-03-21T17:27:01Z

💔 Test Failed - build-test-deploy

zekun000 · 2022-03-21T17:55:14Z

/canary

zekun000 · 2022-03-21T18:03:04Z

/canary

aptos-bot · 2022-03-21T18:31:12Z

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/4939
Forge Test Result: all up : 2006 TPS, 2177 ms latency, 2950 ms p99 latency,no expired txns

aptos-bot · 2022-03-21T18:31:15Z

💔 Test Failed - build-test-deploy

aptos-bot · 2022-03-21T21:28:59Z

💥 Tests timed-out

aptos-bot · 2022-03-21T21:39:19Z

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/4964
Forge Test Result: ``

zekun000 · 2022-03-21T22:15:19Z

/canary

Closes: #260

zekun000 · 2022-03-21T23:12:54Z

/canary

aptos-bot · 2022-03-21T23:12:55Z

This PR is already being canaried

aptos-bot · 2022-03-21T23:27:04Z

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/5023
Forge Test Result: all up : 1945 TPS, 2259 ms latency, 3200 ms p99 latency,no expired txns

aptos-bot · 2022-03-21T23:27:07Z

☀️ Canary successful

davidiw · 2022-03-22T18:08:18Z

crates/transaction-emitter/src/lib.rs

@@ -404,7 +400,7 @@ impl<'t, 'd> TxnEmitter<'t, 'd> {
 info!("Creating and minting seeds accounts");
 let mut i = 0;
 let mut seed_accounts = vec![];
- // load vasp account created by AOS directly
+ // // load vasp account created by AOS directly


oops and what is this AOS thing?

davidiw · 2022-03-22T18:09:00Z

crates/transaction-emitter/src/lib.rs

@@ -536,7 +535,7 @@ impl<'t, 'd> TxnEmitter<'t, 'd> {
 self.accounts.len()
 );
 println!("Mint is done");
- tokio::time::sleep(Duration::from_secs(60)).await;
+ // tokio::time::sleep(Duration::from_secs(60)).await;


davidiw · 2022-03-22T18:09:00Z

crates/transaction-emitter/src/lib.rs

@@ -536,7 +535,7 @@ impl<'t, 'd> TxnEmitter<'t, 'd> {
 self.accounts.len()
 );
 println!("Mint is done");
- tokio::time::sleep(Duration::from_secs(60)).await;
+ // tokio::time::sleep(Duration::from_secs(60)).await;


davidiw · 2022-03-22T18:11:23Z

testsuite/forge/src/backend/k8s/cluster_helper.rs

@@ -39,8 +39,7 @@ const VALIDATOR_SCALING_FACTOR: i64 = 3;
 const UTILITIES_SCALING_FACTOR: i64 = 3;
 const TRUSTED_SCALING_FACTOR: i64 = 1;

-// XXX: swap this out for aptos-framework eventually
-const GENESIS_MODULES_DIR: &str = "/aptos/move/modules";
+const GENESIS_MODULES_DIR: &str = "/aptos-framework/move/modules";


davidiw · 2022-03-22T18:11:23Z

testsuite/forge/src/backend/k8s/cluster_helper.rs

@@ -39,8 +39,7 @@ const VALIDATOR_SCALING_FACTOR: i64 = 3;
 const UTILITIES_SCALING_FACTOR: i64 = 3;
 const TRUSTED_SCALING_FACTOR: i64 = 1;

-// XXX: swap this out for aptos-framework eventually
-const GENESIS_MODULES_DIR: &str = "/aptos/move/modules";
+const GENESIS_MODULES_DIR: &str = "/aptos-framework/move/modules";


davidiw · 2022-03-22T18:11:40Z

testsuite/smoke-test/src/test_utils.rs

@@ -70,7 +70,7 @@ pub async fn transfer_and_reconfig(
 for _ in 0..num_transfers {
 // Reconfigurations have a 20% chance of being executed
 if random::<u16>() % 5 == 0 {
- let diem_version = client.get_aptos_version().await.unwrap();
+ let diem_version = client.get_dpn_version().await.unwrap();


davidiw · 2022-03-22T18:11:46Z

testsuite/smoke-test/src/test_utils.rs

@@ -86,7 +86,7 @@ pub async fn transfer_and_reconfig(

 pub async fn assert_balance(client: &RestClient, account: &LocalAccount, balance: u64) {
 let balances = client
- .get_account_balances(account.address())
+ .get_dpn_account_balances(account.address())


davidiw · 2022-03-22T18:11:46Z

testsuite/smoke-test/src/test_utils.rs

@@ -86,7 +86,7 @@ pub async fn transfer_and_reconfig(

 pub async fn assert_balance(client: &RestClient, account: &LocalAccount, balance: u64) {
 let balances = client
- .get_account_balances(account.address())
+ .get_dpn_account_balances(account.address())


I guess this isn't forge, it is smoke test...

davidiw · 2022-03-22T18:12:17Z

crates/aptos-rest-client/src/lib.rs

+ .await
+ }
+
+ pub async fn get_account_balances(&self, address: AccountAddress) -> Result<Response<Balance>> {


but there aren't plural? balance

davidiw · 2022-03-22T18:12:17Z

crates/aptos-rest-client/src/lib.rs

+ .await
+ }
+
+ pub async fn get_account_balances(&self, address: AccountAddress) -> Result<Response<Balance>> {


but there aren't plural? balance

zekun000 · 2022-03-22T18:49:42Z

/land

Closes: aptos-labs#260

aptos-bot · 2022-03-22T19:18:58Z

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/5199
Forge Test Result: all up : 1967 TPS, 2218 ms latency, 3050 ms p99 latency,no expired txns

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13937) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13935) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (aptos-labs#260) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (aptos-labs#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

…lexity check (#260) (#13936) * improve metadata check efficiency * mark normalized types as deprecated * improve module complexity check * Update timed_features.rs * Add activation time * Update feature flag name * [release-1.15] Deactivate broken package overrides (#13797) Renaming the tomls for deactivating the tests * Update timed_features.rs --------- Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Wolfgang Grieskamp <wg@aptoslabs.com>

zekun000 force-pushed the framework branch 2 times, most recently from 345c521 to 1013197 Compare March 21, 2022 16:55

zekun000 force-pushed the framework branch from 1013197 to 0091e4e Compare March 21, 2022 16:57

zekun000 force-pushed the framework branch from 0091e4e to cc1f8bc Compare March 21, 2022 17:54

zekun000 force-pushed the framework branch from cc1f8bc to 8e26680 Compare March 21, 2022 18:01

zekun000 force-pushed the framework branch from 8e26680 to 097dacc Compare March 21, 2022 18:02

zekun000 requested a review from davidiw March 21, 2022 18:28

zekun000 force-pushed the framework branch from 097dacc to 6e437ce Compare March 21, 2022 18:36

aptos-bot pushed a commit that referenced this pull request Mar 21, 2022

[AptosFramework] migrate forge tests

ced7dd2

Closes: #260

davidiw approved these changes Mar 22, 2022

View reviewed changes

zekun000 force-pushed the framework branch from 6e437ce to 33b41d8 Compare March 22, 2022 18:46

[AptosFramework] migrate forge tests

1de250f

Closes: aptos-labs#260

aptos-bot force-pushed the framework branch from 33b41d8 to 1de250f Compare March 22, 2022 19:19

aptos-bot closed this in 1de250f Mar 22, 2022

aptos-bot merged commit 1de250f into aptos-labs:main Mar 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AptosFramework] migrate forge tests #260

[AptosFramework] migrate forge tests #260

zekun000 commented Mar 21, 2022

netlify bot commented Mar 21, 2022 •

edited

Loading

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

davidiw Mar 22, 2022

zekun000 commented Mar 22, 2022

aptos-bot commented Mar 22, 2022

[AptosFramework] migrate forge tests #260

[AptosFramework] migrate forge tests #260

Conversation

zekun000 commented Mar 21, 2022

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

If targeting a release branch, please fill the below out as well

netlify bot commented Mar 21, 2022 • edited Loading

✅ Deploy Preview for aptos-developer-docs ready!

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

zekun000 commented Mar 21, 2022

zekun000 commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

aptos-bot commented Mar 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zekun000 commented Mar 22, 2022

aptos-bot commented Mar 22, 2022

netlify bot commented Mar 21, 2022 •

edited

Loading